-
Notifications
You must be signed in to change notification settings - Fork 407
feat(Core): fix #910, add a flag to allow user to check duplicate Zone error. #1093
Conversation
1843c10
to
858ed49
Compare
…cate Zone error
@JiaLiPassion Any idea when this fix will be released? |
@JiaLiPassion there is a similar issue, i believe, with importing native-shim in polyfills when an Angular Element tries to consume another Angular Element. It'd be great if the forthcoming zone fix would address that issue as well. Thank you. |
@RichardZandi, sure, thank you for the information. |
Do we have any update on when this will release? This prevents using angular elements in another angular app |
@benoitjchevalier, I am not sure about the release date, you can use this branch for test by updating your
|
@JiaLiPassion thanks for the tips, we nicked your fix from a zip file you posted in another issue and added it to our project but pointing to the branch will be cleaner. It solves our problem 👍 . However we're planning on distributing a packaged js file with a bunch of angular element, so we don't have control over whether consuming angular application will have this fix, hence eagerly waiting for it :) Thank you for your work! |
I need to subscribe myself to this issue, waiting for a release of the fix. |
Also waiting for an official release within Angular... |
@JiaLiPassion solutions works for me. how is angular 7.0.0 released without this? |
@benoitjchevalier do you have a link for the zip please ? thanks |
@hyahyaoui I ended up forking and manually integrating one of the PR that hasn't been merged yet and rebuilt it: |
is this fix released, I need to fix similar issue. |
@nakshay, yes, this is released, you can check it with |
fix #910.
add a flag,
__zone_symbol__forceDuplicateZoneCheck
to let user choose whether to throwerror
when loadduplicate
zone.js.By default, if the
global['Zone']
is fromzone.js
, no error will be thrown, and if theflag
is set totrure
, then we will throw the error.sometimes user may not want this
Zone already loaded
error.For example,
we have two web pages, page1 includes
zone.js
, page2 doesn't.and the 1st time user load page1 and page2, everything work fine,
but when user load page2 again, error occurs because global['Zone'] already exists.
so we add a flag to let user choose whether to throw this error or not.